From 59bd3d1d661764485c7ad82fd31d779b5467b318 Mon Sep 17 00:00:00 2001 From: JonShard Date: Thu, 20 Aug 2026 12:22:07 +0200 Subject: [PATCH] Warning hunt --- Scenes/AlgoScene.tscn | 6 +++--- Scenes/JonScene.tscn | 6 +++--- Scenes/mainMenu.tscn | 6 +++--- Scenes/multiPlayer.tscn | 6 +++--- Scenes/test_small.tscn | 6 +++--- UI/progress_bar_3d.gd | 2 ++ .../objects/viewport_2d_in_3d.tscn | 11 +---------- documentation/library_changes.md | 19 +++++++++++++++++++ test/multiPlayerTest.tscn | 6 +++--- 9 files changed, 40 insertions(+), 28 deletions(-) diff --git a/Scenes/AlgoScene.tscn b/Scenes/AlgoScene.tscn index 46cdb9d..9a0651d 100644 --- a/Scenes/AlgoScene.tscn +++ b/Scenes/AlgoScene.tscn @@ -29,10 +29,10 @@ size = Vector3(16, 0.1, 16) background_mode = 2 sky = ExtResource("5_kh26v") reflected_light_source = 2 -ssr_enabled = true +ssr_enabled = false ssao_enabled = true -ssil_enabled = true -sdfgi_enabled = true +ssil_enabled = false +sdfgi_enabled = false [sub_resource type="BoxShape3D" id="BoxShape3D_24d3s"] size = Vector3(16, 10, 0.1) diff --git a/Scenes/JonScene.tscn b/Scenes/JonScene.tscn index c14f4e4..f883dcc 100644 --- a/Scenes/JonScene.tscn +++ b/Scenes/JonScene.tscn @@ -30,10 +30,10 @@ ambient_light_source = 3 ambient_light_color = Color(1, 1, 1, 1) ambient_light_sky_contribution = 0.9 reflected_light_source = 2 -ssr_enabled = true +ssr_enabled = false ssao_enabled = true -ssil_enabled = true -sdfgi_enabled = true +ssil_enabled = false +sdfgi_enabled = false [sub_resource type="BoxShape3D" id="BoxShape3D_vlqg6"] size = Vector3(20, 0.1, 20) diff --git a/Scenes/mainMenu.tscn b/Scenes/mainMenu.tscn index cd4c661..b8cfc4e 100644 --- a/Scenes/mainMenu.tscn +++ b/Scenes/mainMenu.tscn @@ -18,10 +18,10 @@ size = Vector3(15, 0.1, 15) background_mode = 2 sky = ExtResource("5_l1qm6") reflected_light_source = 2 -ssr_enabled = true +ssr_enabled = false ssao_enabled = true -ssil_enabled = true -sdfgi_enabled = true +ssil_enabled = false +sdfgi_enabled = false [node name="Main" type="Node3D" unique_id=1312265607] script = ExtResource("1_jfr2g") diff --git a/Scenes/multiPlayer.tscn b/Scenes/multiPlayer.tscn index c31b5e3..3f07e7b 100644 --- a/Scenes/multiPlayer.tscn +++ b/Scenes/multiPlayer.tscn @@ -24,10 +24,10 @@ size = Vector3(15, 0.1, 15) background_mode = 2 sky = ExtResource("5_c3xgf") reflected_light_source = 2 -ssr_enabled = true +ssr_enabled = false ssao_enabled = true -ssil_enabled = true -sdfgi_enabled = true +ssil_enabled = false +sdfgi_enabled = false [sub_resource type="BoxShape3D" id="BoxShape3D_arao0"] size = Vector3(15, 20, 0.1) diff --git a/Scenes/test_small.tscn b/Scenes/test_small.tscn index 31dffca..3c65da5 100644 --- a/Scenes/test_small.tscn +++ b/Scenes/test_small.tscn @@ -24,10 +24,10 @@ ambient_light_source = 3 ambient_light_color = Color(1, 1, 1, 1) ambient_light_sky_contribution = 0.9 reflected_light_source = 2 -ssr_enabled = true +ssr_enabled = false ssao_enabled = true -ssil_enabled = true -sdfgi_enabled = true +ssil_enabled = false +sdfgi_enabled = false [sub_resource type="BoxShape3D" id="BoxShape3D_vlqg6"] size = Vector3(20, 0.1, 20) diff --git a/UI/progress_bar_3d.gd b/UI/progress_bar_3d.gd index 679e029..48060c3 100644 --- a/UI/progress_bar_3d.gd +++ b/UI/progress_bar_3d.gd @@ -10,6 +10,8 @@ class_name ProgressBar3D func _ready() -> void: Helper.check_reference(self, progress_bar, ProgressBar) + # Rebind now that SubViewport is guaranteed live, avoiding a stale ViewportTexture. + sprite_3d.texture = sprite_3d.get_node(^"SubViewport").get_texture() if y_billboard: $Sprite3D.billboard = BaseMaterial3D.BillboardMode.BILLBOARD_FIXED_Y diff --git a/addons/godot-xr-tools/objects/viewport_2d_in_3d.tscn b/addons/godot-xr-tools/objects/viewport_2d_in_3d.tscn index 71e2269..5eb38db 100644 --- a/addons/godot-xr-tools/objects/viewport_2d_in_3d.tscn +++ b/addons/godot-xr-tools/objects/viewport_2d_in_3d.tscn @@ -1,4 +1,4 @@ -[gd_scene load_steps=7 format=3 uid="uid://clujaf3u776a3"] +[gd_scene load_steps=5 format=3 uid="uid://clujaf3u776a3"] [ext_resource type="Script" uid="uid://eavk7267igp7" path="res://addons/godot-xr-tools/objects/viewport_2d_in_3d.gd" id="1"] [ext_resource type="Script" uid="uid://cpl5yiyf1ypft" path="res://addons/godot-xr-tools/objects/viewport_2d_in_3d_body.gd" id="2"] @@ -7,14 +7,6 @@ resource_local_to_scene = true size = Vector2(3, 2) -[sub_resource type="ViewportTexture" id="ViewportTexture_ufe4n"] - -[sub_resource type="StandardMaterial3D" id="StandardMaterial3D_fvml0"] -transparency = 1 -cull_mode = 2 -albedo_texture = SubResource("ViewportTexture_ufe4n") -texture_filter = 1 - [sub_resource type="BoxShape3D" id="4"] resource_local_to_scene = true size = Vector3(3, 2, 0.02) @@ -34,7 +26,6 @@ render_target_update_mode = 1 [node name="Screen" type="MeshInstance3D" parent="."] mesh = SubResource("1") -surface_material_override/0 = SubResource("StandardMaterial3D_fvml0") [node name="StaticBody3D" type="StaticBody3D" parent="."] collision_layer = 5242881 diff --git a/documentation/library_changes.md b/documentation/library_changes.md index 9b0b0de..5fe7d82 100644 --- a/documentation/library_changes.md +++ b/documentation/library_changes.md @@ -19,3 +19,22 @@ Add (what) to singal dropped in snap_zone picked_up_object.let_go(self, Vector3.ZERO, Vector3.ZERO) picked_up_object = null highlight_updated.emit(self, enabled) + + +viewport_2d_in_3d.tscn: + Removed the baked ViewportTexture sub-resource (no viewport_path set, genuinely + invalid) that was the default material on the Screen mesh. The script always + builds and swaps in its own material at _ready(), so the baked one only + existed to be briefly invalid before being discarded, printing a spurious + "Viewport Texture must be set to use it" error on every instance (MainMenuPanel3D + at boot, the player's shop_menu_3d on avatar spawn). + Removed: + [sub_resource type="ViewportTexture" id="ViewportTexture_ufe4n"] + + [sub_resource type="StandardMaterial3D" id="StandardMaterial3D_fvml0"] + transparency = 1 + cull_mode = 2 + albedo_texture = SubResource("ViewportTexture_ufe4n") + texture_filter = 1 + And the reference to it on the Screen node: + surface_material_override/0 = SubResource("StandardMaterial3D_fvml0") diff --git a/test/multiPlayerTest.tscn b/test/multiPlayerTest.tscn index 2eaf099..a558420 100644 --- a/test/multiPlayerTest.tscn +++ b/test/multiPlayerTest.tscn @@ -24,10 +24,10 @@ size = Vector3(15, 0.1, 15) background_mode = 2 sky = ExtResource("4_081u3") reflected_light_source = 2 -ssr_enabled = true +ssr_enabled = false ssao_enabled = true -ssil_enabled = true -sdfgi_enabled = true +ssil_enabled = false +sdfgi_enabled = false [sub_resource type="BoxShape3D" id="BoxShape3D_arao0"] size = Vector3(15, 20, 0.1)