From 8b6f444d55e9263fc414a613db415fe770ebcaa9 Mon Sep 17 00:00:00 2001 From: JonShard Date: Tue, 28 Jul 2026 19:16:35 +0200 Subject: [PATCH] Fix XRTools library bug that didn't nil check in pickup --- addons/godot-xr-tools/functions/function_pickup.gd | 3 ++- library_changes.md | 6 ++++++ 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 library_changes.md diff --git a/addons/godot-xr-tools/functions/function_pickup.gd b/addons/godot-xr-tools/functions/function_pickup.gd index 1bfb17a..56c92f0 100644 --- a/addons/godot-xr-tools/functions/function_pickup.gd +++ b/addons/godot-xr-tools/functions/function_pickup.gd @@ -437,7 +437,8 @@ func _pick_up_object(target: Node3D) -> void: # Pick up our target. Note, target may do instant drop_and_free picked_up_ranged = not _object_in_grab_area.has(target) picked_up_object = target - target.pick_up(self) + if target and target.has_method("pick_up"): + target.pick_up(self) # If object picked up then emit signal if is_instance_valid(picked_up_object): diff --git a/library_changes.md b/library_changes.md new file mode 100644 index 0000000..4c14be1 --- /dev/null +++ b/library_changes.md @@ -0,0 +1,6 @@ + + +function_pickup.gd: + Add nil check in func _pick_up_object(target: Node3D) + 440: if target and target.has_method("pick_up"): + target.pick_up(self)